Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1009 - Adjust search button reset action #1017

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Fix #1009 - Adjust search button reset action #1017

merged 1 commit into from
Aug 18, 2021

Conversation

maxxcrawford
Copy link
Contributor

STR:

  • Log into Relay
  • Create multiple aliases
  • Use search filter
  • Click "X" in search filter
  • Expected: Input into the search bar is cleared, and the "Search aliases" placeholder text is restored.

@maxxcrawford maxxcrawford requested a review from codemist August 16, 2021 20:19
@maxxcrawford maxxcrawford linked an issue Aug 16, 2021 that may be closed by this pull request
"x" button behavior in Search aliases bar could be improved #1009
Closed
@maxxcrawford maxxcrawford added the need-review This PR is ready for review label Aug 17, 2021
@maxxcrawford maxxcrawford removed the need-review This PR is ready for review label Aug 17, 2021
@maxxcrawford maxxcrawford merged commit 158dc5b into main Aug 18, 2021
@maxxcrawford maxxcrawford deleted the 1009-search-close-button-fix branch August 18, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codemist codemist codemist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"x" button behavior in Search aliases bar could be improved
2 participants
@maxxcrawford @codemist