Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1015 - Survey background colors are now purple when user is premium #1021

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

maxxcrawford
Copy link
Contributor

Preview:

image

@maxxcrawford maxxcrawford requested a review from codemist August 17, 2021 19:44
@maxxcrawford maxxcrawford added the need-review This PR is ready for review label Aug 17, 2021
@@ -6,6 +6,10 @@
ul {
list-style-type: none;
}

.is-premium & {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the & at the end of this class do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a parent selector, which is pure SCSS Magic™. It's the same as writing .is-premium .recruitment-banner.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, .is-premium is being added to the <body>, so it's influencing/cascading downstream to the banners.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh I see! Gotcha

@maxxcrawford maxxcrawford requested a review from codemist August 20, 2021 16:36
@@ -6,6 +6,10 @@
ul {
list-style-type: none;
}

.is-premium & {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh I see! Gotcha

@codemist codemist merged commit 7b194f2 into main Aug 20, 2021
@codemist codemist deleted the 1015-banner-premium-visibility branch August 20, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review This PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants