Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add zh-tw and zh-cn to LANGUAGES #1030

Merged
merged 1 commit into from
Aug 24, 2021
Merged

add zh-tw and zh-cn to LANGUAGES #1030

merged 1 commit into from
Aug 24, 2021

Conversation

groovecoder
Copy link
Member

This is perhaps a more Djangonic way to fix our language negotiation for zh-tw and zh-cn. (Alternative to #1029)

@groovecoder groovecoder requested a review from say-yawn August 23, 2021 14:22
@groovecoder groovecoder mentioned this pull request Aug 23, 2021
Closed
@groovecoder groovecoder force-pushed the add-zh-langs-to-LANGUAGES branch from 548f429 to e8fa42c Compare August 23, 2021 14:26
@say-yawn
Copy link
Contributor

say-yawn commented Aug 24, 2021 •
edited
Loading

Tested the following languages on Firefox:

  • Chinese [zh] - site returns in English
  • Singapore Chinese [zh-sg] - site returns in English
  • Hong Kong Chinese [zh-hk] - site returns in English
  • China Chinese [zh-cn] - site returns in English
  • Taiwanese Chinese [zh-tw] - site returns in Taiwanese Chinese
    These are expected because currently we only have Taiwanese Chinese translation for Relay website.

say-yawn
say-yawn approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@say-yawn say-yawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A good follow-up is add a fall-back for similar languages if we don't already have the language translated. E.g. no Singapore Chinese? Fall back to Chinese.

@say-yawn say-yawn merged commit 2e63a7e into main Aug 24, 2021
@groovecoder groovecoder deleted the add-zh-langs-to-LANGUAGES branch October 7, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@say-yawn say-yawn say-yawn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@groovecoder @say-yawn