Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple Homepage Hero Image Text/Rotator #1066

Merged
merged 5 commits into from
Sep 1, 2021
Merged

Conversation

maxxcrawford
Copy link
Contributor

The homepage rotator now has the strings that were embedded in them outside, so that they can display in the users' requested language.

@maxxcrawford maxxcrawford requested a review from codemist August 31, 2021 18:35
@maxxcrawford maxxcrawford added the 🛑 Do Not Merge Do not merge this PR, even if approved. label Aug 31, 2021
@maxxcrawford maxxcrawford marked this pull request as ready for review August 31, 2021 18:35
@maxxcrawford maxxcrawford changed the title Decouple Homepage Hero Image Text/Rotator 🛑 DNM 🛑 / Decouple Homepage Hero Image Text/Rotator Aug 31, 2021
@maxxcrawford maxxcrawford temporarily deployed to fx-private-relay August 31, 2021 19:51 Inactive
Copy link
Collaborator

@codemist codemist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's some Protocol-ed CSS!

static/scss/pages/home.scss Outdated Show resolved Hide resolved
@maxxcrawford maxxcrawford temporarily deployed to fx-private-relay August 31, 2021 21:18 Inactive
@maxxcrawford maxxcrawford temporarily deployed to fx-private-relay September 1, 2021 14:30 Inactive
@maxxcrawford maxxcrawford changed the title 🛑 DNM 🛑 / Decouple Homepage Hero Image Text/Rotator Decouple Homepage Hero Image Text/Rotator Sep 1, 2021
@maxxcrawford maxxcrawford merged commit 80ed22d into main Sep 1, 2021
@maxxcrawford maxxcrawford deleted the 821-homepage-hero-l10n branch September 1, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛑 Do Not Merge Do not merge this PR, even if approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants