Upgrade gulp-sass to 5.0.0, add package-lock.json file to be tracked #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc/ @lloan |
maxxcrawford
commented
Sep 7, 2021
maxxcrawford
force-pushed
the
gulp-sass-upgrade
branch
from
9b94a38 to
85b8303
Compare
… to ignore warning flags
maxxcrawford
commented
Sep 7, 2021
| "merge-stream": "^2.0.0" | ||
| "gulp-sass": "^5.0.0", | ||
| "merge-stream": "^2.0.0", | ||
| "sass": "1.32.13" |
There was a problem hiding this comment.
Note that sass is 🔒 locked into 1.32.13. Otherwise every single SCSS compile gives 30+ warnings about the Protocol library that cannot be quieted. It makes the console output impossible.
moz-astults
approved these changes
Sep 7, 2021
toufali
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces 6 high vulnerabilities and adds a package-lock.json file.
found 9 vulnerabilities (1 low, 2 moderate, 6 high)=>found 3 vulnerabilities (1 low, 2 moderate)Note – I used the this guide to upgrade
gulp-sass. This new version requires you to define a compiler. I went with https://www.npmjs.com/package/sass as it is maintained. (Alternate wasnode-sasswhich was deprecated back in Oct 2020.Also, I realized we aren't tracking a package-lock.json file as it is a known security practice. LMK if there's a better way to generate this than just from my local.