Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create codeql-analysis.yml #1468

Merged
merged 4 commits into from
Jan 21, 2022
Merged

Create codeql-analysis.yml #1468

merged 4 commits into from
Jan 21, 2022

Conversation

groovecoder
Copy link
Member

No description provided.

@groovecoder groovecoder force-pushed the add-codeql-analysis.yml branch from 826f2f3 to c2ace4e Compare January 19, 2022 15:39
@groovecoder
Copy link
Member Author

Okay, I like this enough to leave it on our PRs until something comes up that makes it too noisy or annoying with false positives. It helped me find a couple places where we could add some additional defensive coding:

  • add noopener noreferrer to our email wrapper links
  • html- and shell-escape input that comes from outside the app

In all cases, the alerts here were not real vulnerabilities, but I like tools-that-teach-secure coding, so I like this. 😀

Copy link
Collaborator

@Vinnl Vinnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

.github/workflows/codeql-analysis.yml Outdated Show resolved Hide resolved
@groovecoder groovecoder merged commit 68df561 into main Jan 21, 2022
@groovecoder groovecoder deleted the add-codeql-analysis.yml branch January 21, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants