Refinement for the New Feature Announcement area #1579
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of issues identified in #1561. Specifically:
#1561 (comment)
Done in c9a159c.
#1561 (review)
Done in a967d58.
Kooha-03-01-2022-14-32-10.mp4
It also fixes #1583.
As for
Since it switches to a drop-down menu on mobile, I decided to just not show it there for now, since that interaction (a drop-down in a drop-down) can get very gnarly very quickly. It's there in #1562, though that might at some point need to transition to a drop-down as well.
How to test:
/static/scss/libs/protocol/css/includes/tokens/dist/index.scss
).