Store attachments as a list #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store and load attachments as a list of tuples (name, data_stream),
rather than a dict {name: data_stream}. This allows multiple attachments
to have the same name (or None if filenames are omitted).
groovecoder
force-pushed
the
attachments-as-list-1559
branch
from
cf0fc25 to
56db6a3
Compare
|
I rebased this on the latest |
say-yawn
approved these changes
Mar 8, 2022
say-yawn
added
🛑 Do Not Merge
|
Merged because the release date is Thursday, not tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store and load attachments as a list of tuples
(name, data_stream), rather than a dict{name: data_stream}. This allows multiple attachments to have the same name (orNoneif filenames are omitted).This PR fixes #1559
How to test: