-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update from Python 3.7 to 3.9 #1624
Conversation
This avoids a warning with `-W default`: ResourceWarning: unclosed file <_io.BufferedRandom name=14>
75a2bb5
to
1814229
Compare
✅ Deploy Preview for fx-relay-demo canceled.
|
Rebased on main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and spot-checks work: tests passed, and I spot-checked sending and receiving emails, replies, and with attachments too.
@Vinnl - this turned out to be fairly easy, but it still may cause conflicts or merge issues with the React changes, so please review and merge on your schedule. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jwhitlock React changes have already been merged in, and I don't see anything in here that should conflict with it, so feel free to merge! (And after the migration we can move away from Gulp, so that should resolve the django-gulp
error as well.)
Update to Python 3.9.10 in the Dockerfile and Heroku. This PR fixes #1591
How to test:
python3.9 -X dev -m pytest
python3.9 -X dev -m ./manage.py runserver
There was a warning about unclosed files in
GetAttachmentTests
:This is fixed by closing the temporary attachment stream during test teardown.
This leaves a few warnings that can be ignored for now:
pytest.yield_fixture warning
During test setup:
This should be fixed by upgrading to pytest-django 4.0.0 or later, which support Python 3.9 and drops support for
pytest
before 5.4yaml.dump warning
Collected during test run:
This was filed upstream (axnsan12/drf-yasg#765), but there has been no response in two months.
Unclosed .env warning
When starting the development server:
This is included by django-gulp. There's no issue filed, but also the projects haven't been update for years...