-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For MPP-1639: Add RelayAddress.used_on field #1713
Conversation
4863a46
to
efdeb86
Compare
✅ Deploy Preview for fx-relay-demo canceled.
|
591dc8c
to
fd6a53a
Compare
Note: I updated this PR to add E.g.:
So, are there other API endpoints we could add some of the url param lookups to simplify code on the front-end? |
Add django-filter for API-wide filtering more wip
fd6a53a
to
a5ca9f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @groovecoder, the tests steps worked. I've got one question and one field type suggestion - see in-line comments.
0c55b01
to
f6da28c
Compare
Changed to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @groovecoder! 👏 good job re-writing the migration! (watch out @maxxcrawford if you migrated)
This PR is for MPP-1639.
How to test:
python manage.py migrate
used_on
fieldused_on
field of an address. (e.g.,disneyplus.com,netflix.com