Remove cached data when logging out #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although we now properly detect that a user is logged out after mocking logout, the user's data would still be cached, such as the fact that they're a Premium user, causing the header to still be in the Premium theme. With this change, user data is also cleared. Note that this only affected when running using the dev server, as authentication in production involves full page reloads and hence the clearing of all in-memory data.
groovecoder
approved these changes
Apr 21, 2022
| // Revalidate account data to reflect logged out status. | ||
| // Note that the `clear` method exists, even though it's not exposed on the | ||
| // type yet: | ||
| // https://github.com/vercel/swr/issues/161#issuecomment-1079198998 |
There was a problem hiding this comment.
praise: thanks for sending a PR upstream! I subscribed to it to hopefully help remember when we can remove this work-around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1777 (review) by @groovecoder.
Although we now properly detect that a user is logged out after
mocking logout, the user's data would still be cached, such as the
fact that they're a Premium user, causing the header to still be
in the Premium theme.
With this change, user data is also cleared.
Note that this only affected when running using the dev server, as
authentication in production involves full page reloads and hence
the clearing of all in-memory data.
How to test: Log in as a Premium user when running using the dev server. Now logout. Observe that the "Sign up" and "Sign in" buttons are visible again, and that the header is now dark.
/static/scss/libs/protocol/css/includes/tokens/dist/index.scss).