Remove transitionary "type" property on masks #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxxcrawford
approved these changes
Jun 8, 2022
| @@ -3,8 +3,6 @@ import { useAddonData } from "./addon"; | |||
| import { AliasData, isRandomAlias } from "./api/aliases"; | |||
|
|
|||
| export type LocalLabel = { | |||
| /** `type` is to allow for a transition period while people migrate to a new add-on version that uses `mask_type` */ | |||
| type: "random" | "custom"; | |||
| mask_type: "random" | "custom"; | |||
There was a problem hiding this comment.
suggestion/enhancement (nit): Can you include a comment on what these two types mean?
This property was preserved to allow for a transitory period in which people were still using an older add-on version that did not preserve the API's equivalent `mask_type` property. But now that pretty much everyone has the newer add-on version, we no longer need the redundant `type` property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This property was preserved to allow for a transitory period in
which people were still using an older add-on version that did not
preserve the API's equivalent
mask_typeproperty. But now thatpretty much everyone has the newer add-on version, we no longer
need the redundant
typeproperty:This is the (independent) sister PR to mozilla/fx-private-relay-add-on#361, and a follow-up to #1990.
Screenshot (if applicable)
Not applicable.
How to test
There should be no changed behaviour compared to
main, especially with server-side label storage turned off.Checklist
/static/scss/libs/protocol/css/includes/tokens/dist/index.scss).