Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jest from 27.5.1 to 28.1.1 in /frontend #2051

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 7, 2022

Bumps jest from 27.5.1 to 28.1.1.

Release notes

Sourced from jest's releases.

v28.1.1

Features

  • [jest] Expose Config type (#12848)
  • [@jest/reporters] Improve GitHubActionsReporters annotation format (#12826)
  • [@jest/types] Infer argument types passed to test and describe callback functions from each tables (#12885, #12905)

Fixes

  • [@jest/expect-utils] Fix deep equality of ImmutableJS OrderedMaps (#12763)
  • [jest-docblock] Handle multiline comments in parseWithComments (#12845)
  • [jest-mock] Improve spyOn error messages (#12901)
  • [jest-runtime] Correctly report V8 coverage with resetModules: true (#12912)
  • [jest-worker] Make JestWorkerFarm helper type to include methods of worker module that take more than one argument (#12839)

Chore & Maintenance

  • [docs] Updated docs to indicate that jest-environment-jsdom is a separate package #12828

  • [docs] Document the comments used by coverage providers #12835

  • [docs] Use docusaurus-remark-plugin-tab-blocks to format tabs with code examples (#12859)

  • [jest-haste-map] Bump walker version (#12324)

  • [expect] Adjust typings of lastCalledWith, nthCalledWith, toBeCalledWith matchers to allow a case there a mock was called with no arguments (#12807)

  • [@jest/expect-utils] Fix deep equality of ImmutableJS Lists (#12763)

  • [jest-core] Do not collect SIGNREQUEST as open handles (#12789)

New Contributors

Full Changelog: jestjs/jest@v28.1.0...v28.1.1

v28.1.0

Features

  • [jest-circus] Add failing test modifier that inverts the behaviour of tests (#12610)
  • [jest-environment-node, jest-environment-jsdom] Allow specifying customExportConditions (#12774)

Fixes

... (truncated)

Changelog

Sourced from jest's changelog.

28.1.1

Features

  • [jest] Expose Config type (#12848)
  • [@jest/reporters] Improve GitHubActionsReporters annotation format (#12826)
  • [@jest/types] Infer argument types passed to test and describe callback functions from each tables (#12885, #12905)

Fixes

  • [@jest/expect-utils] Fix deep equality of ImmutableJS OrderedMaps (#12763)
  • [jest-docblock] Handle multiline comments in parseWithComments (#12845)
  • [jest-mock] Improve spyOn error messages (#12901)
  • [jest-runtime] Correctly report V8 coverage with resetModules: true (#12912)
  • [jest-worker] Make JestWorkerFarm helper type to include methods of worker module that take more than one argument (#12839)

Chore & Maintenance

  • [docs] Updated docs to indicate that jest-environment-jsdom is a separate package #12828
  • [docs] Document the comments used by coverage providers #12835
  • [docs] Use docusaurus-remark-plugin-tab-blocks to format tabs with code examples (#12859)
  • [jest-haste-map] Bump walker version (#12324)

28.1.0

Features

  • [jest-circus] Add failing test modifier that inverts the behavior of tests (#12610)
  • [jest-environment-node, jest-environment-jsdom] Allow specifying customExportConditions (#12774)

Fixes

  • [expect] Adjust typings of lastCalledWith, nthCalledWith, toBeCalledWith matchers to allow a case there a mock was called with no arguments (#12807)
  • [@jest/expect-utils] Fix deep equality of ImmutableJS Lists (#12763)
  • [jest-core] Do not collect SIGNREQUEST as open handles (#12789)

Chore & Maintenance

  • [docs] Specified documentation about --filter CLI docs (#12799)
  • [@jest-reporters] Move helper functions from utils.ts into separate files (#12782)
  • [jest-resolve] Replace process.versions.pnp type declaration with @types/pnpapi devDependency (#12783)

28.0.3

Fixes

  • [jest-config] Normalize reporters option defined in presets (#12769)
  • [@jest/reporters] Fix trailing slash in matching coverageThreshold key (#12714)
  • [jest-resolve] Fix (experimental) ESM module mocking for re-exports (#12766)
  • [@jest/transform] Throw better error if an invalid return value if encountered (#12764)

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jun 7, 2022
@netlify
Copy link

netlify bot commented Jun 7, 2022

Deploy Preview for fx-relay-demo failed.

Name Link
🔨 Latest commit 14c2522
🔍 Latest deploy log https://app.netlify.com/sites/fx-relay-demo/deploys/629f3fa9f2fcc90008f26fa9

@Vinnl
Copy link
Collaborator

Vinnl commented Jun 7, 2022

Carrying over from #1951 (comment):

I investigated the failing test here for a bit, and it looks like the <form>'s submit event does not get triggered when pressing the <button type="submit"> (though a click event on the button does get triggered). There's a new version of the user-event library available that it's recommended to upgrade to, but that didn't fix it right away. Pausing that work here for a bit in case it's a bug that gets fixed soon.

(Oh, and also, jest-environment-jsdom needs to be added as an explicit dependency now.)

Edit: upgrade to the new version in #1978, which also had some breaking changes to incorporate. Hopefully that will also help applying this update.

Edit: after some debugging it looks like the waitlist form's onSubmit event handler gets removed? (Add console.log("FORM:", submitButton.form.onSubmit); to the test to see.) This might be intentional; IIRC React 18 handles events at the root or something? So we might need to upgrade to React 18 first (which depends on some other dependencies also becoming compatible with it.)

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/frontend/jest-28.1.1 branch 2 times, most recently from b1a6710 to cba9eea Compare June 13, 2022 07:22
@Vinnl Vinnl added the Review: M Code review time: 1-2 hours label Jun 13, 2022
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/frontend/jest-28.1.1 branch 3 times, most recently from 0928775 to 84f4619 Compare June 20, 2022 07:15
Bumps [jest](https://github.com/facebook/jest/tree/HEAD/packages/jest) from 27.5.1 to 28.1.1.
- [Release notes](https://github.com/facebook/jest/releases)
- [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/jest/commits/v28.1.1/packages/jest)

---
updated-dependencies:
- dependency-name: jest
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/frontend/jest-28.1.1 branch from 84f4619 to c0b0023 Compare June 27, 2022 08:50
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 29, 2022

Superseded by #2141.

@dependabot dependabot bot closed this Jun 29, 2022
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/frontend/jest-28.1.1 branch June 29, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code Review: M Code review time: 1-2 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant