-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag logic to Tracker Removal item in Whats New list #2117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change requested
@@ -307,7 +310,10 @@ export const WhatsNewMenu = (props: Props) => { | |||
}, | |||
}; | |||
// Only show its announcement if tracker removal is live: | |||
if (typeof props.profile.remove_level_one_email_trackers === "boolean") { | |||
if ( | |||
typeof props.profile.remove_level_one_email_trackers === "boolean" && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typeof props.profile.remove_level_one_email_trackers === "boolean" && |
We do not need to check the profile to see if user has enabled remove email tracker since this is news.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wasn't a check to see whether the user has it enabled (it doesn't check for true or false), but just if the back-end provides the value in general (i.e. whether it's of type boolean
rather than undefined
) 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code makes sense, local env is not working so testing in Stage.
Related to #2116