Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPP-1833 Filter buttons have different sizes. #2119

Merged
merged 5 commits into from
Jul 7, 2022
Merged

MPP-1833 Filter buttons have different sizes. #2119

merged 5 commits into from
Jul 7, 2022

Conversation

lloan
Copy link
Contributor

@lloan lloan commented Jun 24, 2022 •
edited
Loading

This PR fixes #1810

New feature description

Following how we’ve handled other UI, we make both buttons full width, and stack them.

Old state:
image

Screenshot (if applicable)

(updated)
image

How to test

  1. Navigate to Relay page and log in.
  2. Go to aliases list and click the filter button above it.
  3. Observe the "Reset" and "Apply" buttons.

Checklist

  • l10n dependencies have been merged, if any.
  • All acceptance criteria are met.
  • I've added or updated relevant docs in the docs/ directory.
  • All UI revisions follow the coding standards, and use Protocol tokens where applicable (see /static/scss/libs/protocol/css/includes/tokens/dist/index.scss).
  • Commits in this PR are minimal and have descriptive commit messages.

@lloan lloan added the Review: µ Code review time: 5 minutes or less label Jun 24, 2022
@lloan lloan self-assigned this Jun 24, 2022
Vinnl
Vinnl approved these changes Jun 24, 2022
View reviewed changes
Copy link
Collaborator

@Vinnl Vinnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@mozilla mozilla deleted a comment from netlify bot Jun 28, 2022
@lloan lloan requested a review from Vinnl June 28, 2022 19:46
@lloan
Copy link
Contributor Author

lloan commented Jun 28, 2022

@Vinnl re-requested a review from you as I made some minor changes to reuse button component for secondary buttons.

Vinnl
Vinnl approved these changes Jun 29, 2022
View reviewed changes
Copy link
Collaborator

@Vinnl Vinnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good too! Hover state of secondary buttons is a bit hard to see, but that's the case in more places in the website unfortunately.

@lloan lloan merged commit 7917ff5 into main Jul 7, 2022
@lloan lloan deleted the MPP-1883-filter-buttons branch July 7, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vinnl Vinnl Vinnl approved these changes

Assignees

@lloan lloan

Labels
Review: µ Code review time: 5 minutes or less
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter buttons have different length and width
2 participants
@lloan @Vinnl