Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search icon being accidentally filled #2144

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Fix search icon being accidentally filled #2144

merged 1 commit into from
Jul 7, 2022

Conversation

Vinnl
Copy link
Collaborator

@Vinnl Vinnl commented Jun 29, 2022 •
edited
Loading

The search icon on mobile looked off since #1998:

image

This fixes #2173 to make it look as intended again:

image

  • l10n changes have been submitted to the l10n repository, if any.
  • I've added a unit test to test for potential regressions of this bug. - N/A, visual change
  • I've added or updated relevant docs in the docs/ directory.
  • All UI revisions follow the coding standards, and use Protocol tokens where applicable (see /frontend/src/styles/tokens.scss).
  • Commits in this PR are minimal and have descriptive commit messages.

@Vinnl
Fix search icon being accidentally filled
160c800 
Initially the `fill: none` was set on the `<svg>`'s `style`
attribute, but when that got blocked by our Content Security
Policy, I didn't properly carry that style over to all relevant
child elements.
@Vinnl Vinnl added the Review: µ Code review time: 5 minutes or less label Jun 29, 2022
@Vinnl Vinnl requested review from lloan and codemist June 29, 2022 21:52
@Vinnl Vinnl self-assigned this Jun 29, 2022
lloan
lloan approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@lloan lloan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Vinnl Vinnl mentioned this pull request Jul 7, 2022
Closed
@Vinnl Vinnl merged commit 7491fe9 into main Jul 7, 2022
@Vinnl Vinnl deleted the fix-icon-fill branch July 7, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lloan lloan lloan approved these changes

@codemist codemist Awaiting requested review from codemist

Assignees

@Vinnl Vinnl

Labels
Review: µ Code review time: 5 minutes or less
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Mobile] Search button is black
2 participants
@Vinnl @lloan