Bump jest from 27.5.1 to 28.1.3 in /frontend

[dependabot]

Bumps jest from 27.5.1 to 28.1.3.

Release notes

Sourced from jest's releases.

v28.1.3

Features

• [jest-leak-detector] Use native FinalizationRegistry when it exists to get rid of external C dependency (#12973)

Fixes

• [jest-changed-files] Fix a lock-up after repeated invocations (#12757)
• [@jest/expect-utils] Fix deep equality of ImmutableJS OrderedSets (#12977)
• [jest-mock] Add index signature support for spyOn types (#13013, #13020)
• [jest-snapshot] Fix indentation of awaited inline snapshots (#12986)

Chore & Maintenance

• [*] Replace internal usage of pretty-format/ConvertAnsi with jest-serializer-ansi-escapes (#12935, #13004)
• [docs] Update spyOn docs (#13000)

New Contributors

• @​joshkel made their first contribution in facebook/jest#12960
• @​enrilzhou made their first contribution in facebook/jest#12973
• @​milahu made their first contribution in facebook/jest#12983
• @​MiguelYax made their first contribution in facebook/jest#13000
• @​kaffarell made their first contribution in facebook/jest#13015
• @​TheKhanj made their first contribution in facebook/jest#12988
• @​Fdawgs made their first contribution in facebook/jest#13019

Full Changelog: jestjs/jest@v28.1.2...v28.1.3

v28.1.2

Fixes

• [jest-runtime] Avoid star type import from @jest/globals (#12949)

Chore & Maintenance

• [docs] Mention that jest-codemods now supports Sinon (#12898)

New Contributors

• @​danbeam made their first contribution in facebook/jest#12898
• @​DanRowe made their first contribution in facebook/jest#12915

Full Changelog: jestjs/jest@v28.1.1...v28.1.2

v28.1.1

Features

• [jest] Expose Config type (#12848)
• [@jest/reporters] Improve GitHubActionsReporters annotation format (#12826)
• [@jest/types] Infer argument types passed to test and describe callback functions from each tables (#12885, #12905)

... (truncated)

Changelog

Sourced from jest's changelog.

28.1.3

Features

• [jest-leak-detector] Use native FinalizationRegistry when it exists to get rid of external C dependency (#12973)

Fixes

• [jest-changed-files] Fix a lock-up after repeated invocations (#12757)
• [@jest/expect-utils] Fix deep equality of ImmutableJS OrderedSets (#12977)
• [jest-mock] Add index signature support for spyOn types (#13013, #13020)
• [jest-snapshot] Fix indentation of awaited inline snapshots (#12986)

Chore & Maintenance

• [*] Replace internal usage of pretty-format/ConvertAnsi with jest-serializer-ansi-escapes (#12935, #13004)
• [docs] Update spyOn docs (#13000)

28.1.2

Fixes

• [jest-runtime] Avoid star type import from @jest/globals (#12949)

Chore & Maintenance

• [docs] Mention that jest-codemods now supports Sinon (#12898)

28.1.1

Features

• [jest] Expose Config type (#12848)
• [@jest/reporters] Improve GitHubActionsReporters annotation format (#12826)
• [@jest/types] Infer argument types passed to test and describe callback functions from each tables (#12885, #12905)

Fixes

• [@jest/expect-utils] Fix deep equality of ImmutableJS OrderedMaps (#12763)
• [jest-docblock] Handle multiline comments in parseWithComments (#12845)
• [jest-mock] Improve spyOn error messages (#12901)
• [jest-runtime] Correctly report V8 coverage with resetModules: true (#12912)
• [jest-worker] Make JestWorkerFarm helper type to include methods of worker module that take more than one argument (#12839)

Chore & Maintenance

• [docs] Updated docs to indicate that jest-environment-jsdom is a separate package #12828
• [docs] Document the comments used by coverage providers #12835
• [docs] Use docusaurus-remark-plugin-tab-blocks to format tabs with code examples (#12859)
• [jest-haste-map] Bump walker version (#12324)

... (truncated)

Commits

• 2cce069 v28.1.3
• 0425de0 chore: bump typescript and related dependencies (#13017)
• 43368be chore: bump jest-runner-tsd (#12981)
• 789965e v28.1.2
• eb954f8 v28.1.1
• 6e6d4b4 chore: bump typescript to v4.7.3 (#12909)
• 3e38157 chore: bump typescript to v4.7 (#12901)
• a841a74 feat(jest): expose Config type from jest (#12848)
• f5db241 v28.1.0
• 1bea778 v28.0.3
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[Vinnl]

Carrying over from #2141 (comment):

I investigated the failing test here for a bit, and it looks like the <form>'s submit event does not get triggered when pressing the <button type="submit"> (though a click event on the button does get triggered). There's a new version of the user-event library available that it's recommended to upgrade to, but that didn't fix it right away. Pausing that work here for a bit in case it's a bug that gets fixed soon.

(Oh, and also, jest-environment-jsdom needs to be added as an explicit dependency now.)

Edit: upgrade to the new version in #1978, which also had some breaking changes to incorporate. Hopefully that will also help applying this update.

Edit: after some debugging it looks like the waitlist form's onSubmit event handler gets removed? (Add console.log("FORM:", submitButton.form.onSubmit); to the test to see.) This might be intentional; IIRC React 18 handles events at the root or something? So we might need to upgrade to React 18 first (which depends on some other dependencies also becoming compatible with it.)

Edit: got some more info: testing-library/user-event#401 seems to suggest needing an up-to-date version of @testing-library/react, which in turn says that it requires React 18. So presumably that is indeed the issue; hopefully soon all our deps will be compatible with React 18. It might be worth it trying to figure out which ones are blocking it.

Edit: one other thing I tried is pressing {Enter} while in the input field, but that doesn't trigger the submit either.

I can manually trigger it with this ugly piece of code:

    const propsProp = Object.keys(submitButton.form).find(key => key.startsWith("__reactProps"));
    submitButton.form[propsProp].onSubmit({ preventDefault: jest.fn() });

If I add a console.log to the submit handler, I can then at least see that getting printed, and with that, the test succeeds.

Edit: OK, and in terms of libraries blocking the upgrade, that mostly appear to be:

• @fluent/react: a Mozilla project, so maybe we can pull some strings (aka submit a PR) there?
• react-aria: should support React 18, but possibly does not mark it as such because it does not yet support strict mode (which we're using).
• @testing-library/react-hooks: appears this will be (/has been?) made redundant.

[Vinnl]

I added two commits, one to migrate, and one to disable the remaining two tests. I'd like to get this upgrade over with, the tests aren't super critical, and unfortunately I haven't been able to figure out why they started failing. I've asked for someone else's review before I merge this.

[Vinnl]

I got one thumbs-up and a no-comment, so...

@dependabot merge