fix MPP-2227: set voice_application_sid for relay number #2257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fx-relay-demo canceled.
|
jwhitlock
approved these changes
Jul 27, 2022
There was a problem hiding this comment.
Thanks @groovecoder! I did this manually when I was testing PR #2227 (very weird how the Jira ticket and PR lined up), the voice API addition. Sorry I didn't include it in my review. I thought it was because I re-used a number from the SMS testing on #2026, and it would have been setup correctly with a new number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #MPP-2227.
How to test:
Since testing requires buying a relay number, probably best to test this on the dev server, where Mozilla is paying for the numbers. ;)