Add tracker removal + promo blocking to interstitial and homepage #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vinnl
force-pushed
the
MPP-1758-promote-tracker-removal
branch
from
1207396 to
3470c0b
Compare
Vinnl
commented
Jul 28, 2022
| @@ -82,6 +82,16 @@ | |||
| margin: 0 auto; | |||
| } | |||
|
|
|||
| .pill { | |||
| background-color: $color-violet-30; | |||
There was a problem hiding this comment.
(The force push just now was to change this from -20 to -30 as per Eduardo's request 😄 )
lloan
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature description
This lists tracker removal as a feature on the homepage (when the feature flag is on - I also toggled it on on the mock site):
Additionally, it lists both promo-blocking and tracker removal on
/premium:How to test
Visit the landing page and
/premium.Checklist
/frontend/src/styles/tokens.scss).