Add a database default for relaynumber.enabled #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a database-enabled default value, the existing v3.6.1 code will continue to work during the period when this migration is run and the new release is not fully deployed.
✅ Deploy Preview for fx-relay-demo canceled.
|
|
See https://github.com/mozilla/fx-private-relay/pull/2259/files#r932432801 for more context |
4 tasks
groovecoder
approved these changes
Jul 29, 2022
Comment on lines
+63
to
+67
| migrations.RunPython( | ||
| code=add_db_default_forward_func, | ||
| reverse_code=migrations.RunPython.noop, | ||
| elidable=True, | ||
| ), |
There was a problem hiding this comment.
Does it matter if this runs before/after the migrations.AddField?
There was a problem hiding this comment.
yes for the PostgreSQL variant, no for the SQLite variant, so yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a database-enabled default value, the existing v3.6.1 code will continue to work during the period when this migration is run and the new release is not fully deployed.
Tested locally with sqlite3 3.37.0 and PostgreSQL 14.4. CircleCI will run tests against both.