Allow scrolling in the tracker report page #2281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using latest changes from: mozilla-services/shavar-prod-lists#589
Usually, <Layout> takes care of this, but since this page is not wrapped in a <Layout>, it needs to ensure it is scrollable by itself.
|
Pushed in 222.07.26.3: 2022.07.26.2...2022.07.26.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main, they also show up as part of this PR. The only real change is 26e9a52, so only that needs to be reviewed.Usually, takes care of this, but since this page is not
wrapped in a , it needs to ensure it is scrollable by
itself.
Note: I based this branch off the tag https://github.com/mozilla/fx-private-relay/releases/tag/2022.07.26.2 so that it can also be added as a hotfix.
This bug was caused by the unfortunate combination of #2177 and #2104 getting worked on around the same time.
This PR fixes #2279.
How to test: visit the tracker removal report and verify that you can scroll the page (compare to
main's version./frontend/src/styles/tokens.scss).