Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @mozilla-protocol/core from 17.0.1 to 18.0.0 #3738

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 4, 2023

Bumps @mozilla-protocol/core from 17.0.1 to 18.0.0.

Release notes

Sourced from @​mozilla-protocol/core's releases.

18.0.0

What's Changed

  • css: Replace get-theme, type-scale functions and theme and type-scale maps with CSS Custom Properties. Sass variables added for legacy support
  • css: Migrates the sass @import with @use and @forward (#755).

Migration Tips

  • This version updates how we internally import SCSS files, from the @import syntax to @use and @forward
  • When importing lib at the head of your project you will use the with keyword instead of stating variables explicitly, like this:
@use '/assets/sass/protocol/includes/lib' with ($font-path: '/protocol/fonts');
  • To use the global namespace for protocol variables you will need to use the as keyword and assign to *:
@use '../includes/lib' as *;
  • if you don't use as you would access variables and mixins from the file using the filename as a namespace:
@use '../includes/lib';
.mzp-c-item {
@​include lib.text-title-md;
color: lib.$color-ink-80;
margin: lib.$spacing-lg 0;
}

  • For more information on the @use and @forward you can visit the offical SCSS documentation or the usage page on the Protocol documentation website

  • This version also moves from using the get-theme function to using css custom properties. A future version of protocol will depreciate both the get-theme and type-scale functions.

  • To migrate from get-theme or type-scale to CSS custom properties, follow this pattern:

  • From this:

.mzp-t-dark {
  background-color: get-theme('background-color-inverse');
  color: get-theme('body-text-color-inverse');
  line-height: type-scale('body-line-height');
}
  • to this:
  • (Note: if you need to support legacy browsers, place the CSS custom properties in a @supports flag and use sass variables as a fall back. Legacy browsers will always be served the default theme.)
.mzp-t-dark {
  background-color: $background-color-inverse;
  color: $body-text-color-inverse;
  line-height: $body-line-height;
</tr></table> 

... (truncated)

Changelog

Sourced from @​mozilla-protocol/core's changelog.

18.0.0

Features

  • css: Replace get-theme, type-scale functions and theme and type-scale maps with CSS Custom Properties. Sass variables added for legacy support
  • css: Migrates the sass @import with @use and @forward (#755).

Migration Tips

  • This version updates how we internally import SCSS files, from the @import syntax to @use and @forward
  • When importing lib at the head of your project you will use the with keyword instead of stating variables explicitly, like this:
@use '/assets/sass/protocol/includes/lib' with ($font-path: '/protocol/fonts');
  • To use the global namespace for protocol variables you will need to use the as keyword and assign to *:
@use '../includes/lib' as *;
  • if you don't use as you would access variables and mixins from the file using the filename as a namespace:
@use '../includes/lib';
.mzp-c-item {
@​include lib.text-title-md;
color: lib.$color-ink-80;
margin: lib.$spacing-lg 0;
}

  • For more information on the @use and @forward you can visit the offical SCSS documentation or the usage page on the Protocol documentation website

  • This version also moves from using the get-theme function to using css custom properties. A future version of protocol will depreciate both the get-theme and type-scale functions.

  • To migrate from get-theme or type-scale to CSS custom properties, follow this pattern:

  • From this:

.mzp-t-dark {
  background-color: get-theme('background-color-inverse');
  color: get-theme('body-text-color-inverse');
  line-height: type-scale('body-line-height');
}
  • to this:
  • (Note: if you need to support legacy browsers, place the CSS custom properties in a @supports flag and use sass variables as a fall back. Legacy browsers will always be served the default theme.)
.mzp-t-dark {
  background-color: $background-color-inverse;
  color: $body-text-color-inverse;
</tr></table> 

... (truncated)

Commits
Maintainer changes

This version was pushed to npm by nathanbarrett24, a new releaser for @​mozilla-protocol/core since your current version.


Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Aug 4, 2023
@jwhitlock
Copy link
Member

It looks like Relay code changes are needed to adopt this update.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/mozilla-protocol/core-18.0.0 branch 2 times, most recently from c56ecd4 to 1a1023b Compare August 10, 2023 09:09
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/mozilla-protocol/core-18.0.0 branch 4 times, most recently from 81e307b to 7827766 Compare August 16, 2023 17:57
@say-yawn say-yawn added the 🛑 Do Not Merge Do not merge this PR, even if approved. label Aug 17, 2023
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/mozilla-protocol/core-18.0.0 branch 3 times, most recently from ace5e6b to 7d90184 Compare August 23, 2023 23:00
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/mozilla-protocol/core-18.0.0 branch from 7d90184 to ac7691b Compare August 28, 2023 15:37
@jwhitlock
Copy link
Member

@dependabot rebase

Bumps [@mozilla-protocol/core](https://github.com/mozilla/protocol) from 17.0.1 to 18.0.0.
- [Release notes](https://github.com/mozilla/protocol/releases)
- [Changelog](https://github.com/mozilla/protocol/blob/main/CHANGELOG.md)
- [Commits](mozilla/protocol@v17.0.1...v18.0.0)

---
updated-dependencies:
- dependency-name: "@mozilla-protocol/core"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/mozilla-protocol/core-18.0.0 branch from ac7691b to 4831e11 Compare December 4, 2023 15:58
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 15, 2024

Superseded by #4314.

@dependabot dependabot bot closed this Jan 15, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/mozilla-protocol/core-18.0.0 branch January 15, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code 🛑 Do Not Merge Do not merge this PR, even if approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants