Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement feedback for telemetry #4168

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Implement feedback for telemetry #4168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d547799
implement feedback for telemetry
lloan Nov 28, 2023
1de2780
update UTM params for banner
lloan Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion frontend/src/components/layout/navigation/whatsnew/WhatsNewMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ import { GiftIcon } from "../../../Icons";
import { useL10n } from "../../../../hooks/l10n";
import { VisuallyHidden } from "../../../VisuallyHidden";
import { useOverlayBugWorkaround } from "../../../../hooks/overlayBugWorkaround";
import { useGaViewPing } from "../../../../hooks/gaViewPing";

export type WhatsNewEntry = {
title: string;
Expand Down Expand Up @@ -344,7 +345,11 @@ export const WhatsNewMenu = (props: Props) => {
? getPeriodicalPremiumSubscribeLink(props.runtimeData, "yearly")
: undefined;

const yearlyPlanRefWithCoupon = `${yearlyPlanLink}&coupon=HOLIDAY20&utm_source=fx-relay&utm_medium=announcement&utm_campaign=holiday-promo-2023`;
const yearlyPlanRefWithCoupon = `${yearlyPlanLink}&coupon=HOLIDAY20&utm_source=relay.firefox.com&utm_medium=whatsnew-announcement&utm_campaign=relay-holiday-promo-2023`;
const getYearlyPlanBtnRef = useGaViewPing({
category: "Holiday Promo News CTA",
label: "holiday-promo-2023-news-cta",
});

const holidayPromo2023: WhatsNewEntry = {
title: l10n.getString("whatsnew-holiday-promo-2023-news-heading"),
Expand All @@ -359,6 +364,7 @@ export const WhatsNewMenu = (props: Props) => {
cta={
<Link
href={yearlyPlanRefWithCoupon}
ref={getYearlyPlanBtnRef}
onClick={() => {
gaEvent({
category: "Holiday Promo News CTA",
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/layout/topmessage/HolidayPromoBanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export const HolidayPromoBanner = (props: Props) => {
}

const utmParams =
"&utm_source=fx-relay&utm_medium=banner&utm_content=holiday-promo-banner-cta&utm_campaign=holiday-promo-2023";
"&utm_source=fx-relay&utm_medium=banner&utm_content=holiday-promo-banner-cta&utm_campaign=relay-holiday-promo-2023";
const subscriberLinkWithCoupon = `${subscribeLink}&coupon=${coupon}${utmParams}`;

return (
Expand Down