Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPP-3597: Fix mobile sizing of step two in free user onboarding #4178

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

rafeerahman
Copy link
Contributor

@rafeerahman rafeerahman commented Nov 30, 2023

This PR fixes MPP-3597.

Bug description

See the picture below

Screenshot of fix

How to test

  • Sign in to a free user with onboarding_free_state = 0.
  • Go to /accounts/profile?utm_campaign=relay-onboarding&utm_source=relay-onboarding&utm_medium=email
  • Go to the second step of this onboarding by clicking generate new mask.
  • Using devtools, click on mobile view and set the width to 360px.
  • Verify that there is no extra space by scrolling horizontally to the right.

Checklist (Definition of Done)

  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • I've added or updated relevant docs in the docs/ directory
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.
  • All UI revisions follow the coding standards, and use Protocol tokens where applicable (see /frontend/src/styles/tokens.scss).
  • Commits in this PR are minimal and have descriptive commit messages.
  • l10n changes have been submitted to the l10n repository, if any.

@rafeerahman rafeerahman requested a review from lloan December 1, 2023 21:57
@rafeerahman rafeerahman self-assigned this Dec 1, 2023
Copy link
Contributor

@lloan lloan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job - was this only affecting iOS devices?

@rafeerahman
Copy link
Contributor Author

Awesome job - was this only affecting iOS devices?

No, was affecting all devices

@rafeerahman rafeerahman added this pull request to the merge queue Dec 4, 2023
Merged via the queue into main with commit 419edc2 Dec 4, 2023
23 checks passed
@rafeerahman rafeerahman deleted the MPP-3597 branch December 4, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants