Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPP-3657 Fix relay address validation against deleted address check #4253

Merged
merged 4 commits into from
Dec 21, 2023
Merged

MPP-3657 Fix relay address validation against deleted address check #4253

merged 4 commits into from
Dec 21, 2023

Conversation

say-yawn
Copy link
Contributor

This PR fixes MPP-3657.

How to test:

@say-yawn say-yawn requested a review from jwhitlock December 21, 2023 16:38
jwhitlock
jwhitlock approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@jwhitlock jwhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @say-yawn, that fixes the issue.

Do you want to include some type hints, or should we do that in a new PR?

@say-yawn
Copy link
Contributor Author

@jwhitlock yes, it was actually part of the acceptance criteria and I forgot. Thanks for bringing it up.

jwhitlock
jwhitlock requested changes Dec 21, 2023
View reviewed changes
Copy link
Member

@jwhitlock jwhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, add some type hints please!

@jwhitlock
Copy link
Member

Can you add a return value from RelayAddress.save so mypy will check the function?

    def save(self, *args, **kwargs) -> None:

jwhitlock
jwhitlock approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@jwhitlock jwhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @say-yawn!

@say-yawn say-yawn added this pull request to the merge queue Dec 21, 2023
Merged via the queue into main with commit 635af06 Dec 21, 2023
23 checks passed
@say-yawn say-yawn deleted the MPP-3657-Fix-RelayAddress-validation-against-DeletedAddress-check branch December 21, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwhitlock jwhitlock jwhitlock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@say-yawn @jwhitlock