for MPP-3467: add googlecloudprofiler to PrivateRelayConfig.ready #4321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groovecoder
force-pushed
the
add-google-cloud-profiler-MPP-3467
branch
6 times, most recently
from
acba5ce to
225d16b
Compare
groovecoder
force-pushed
the
add-google-cloud-profiler-MPP-3467
branch
from
225d16b to
86bc582
Compare
jwhitlock
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Thanks @groovecoder! I didn't see any blockers for merging this, since it represents working code in local dev and Heroku (which took a lot of effort!). I imagine we'll need more changes to get it running in GCP.
I was able to load get_version_info from it's original spot by importing inside the function rather than at the top level. If you want to do that in this PR, please do, but I can also do it in my next PR (#4347) which touches all these files again.
groovecoder
force-pushed
the
add-google-cloud-profiler-MPP-3467
branch
from
86bc582 to
3658fb9
Compare
Also moves get_version_info to privaterelay.apps
groovecoder
force-pushed
the
add-google-cloud-profiler-MPP-3467
branch
from
3658fb9 to
24187e0
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Cloud Profiler
https://cloud.google.com/profiler/docs
https://cloud.google.com/profiler/docs/profiling-python
Screenshot (if applicable)
How to test
Follow the steps in https://github.com/mozilla/fx-private-relay/pull/4321/files#diff-01748e8486974d80818eb9b8c9f623769f0ddb0821f867644d6e113f0dc008d3 for local server setup.
Checklist (Definition of Done)
Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.All acceptance criteria are met.Jira ticket has been updated (if needed) to match changes made during the development process.All UI revisions follow the coding standards, and use Protocol tokens where applicable (see/frontend/src/styles/tokens.scss).l10n changes have been submitted to the l10n repository, if any.