MPP-3726 Set and get when user profile phone was registered #4372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Realphone.verified_date if it exists Fix MPP-3726
Set NULL for older RelayNumbers that we do not know when it was created. Fix MPP-3726
For older RelayNumbers with created_at as None, use RealPhone.verified_date For new RelayNumbers with created_at auto set, user RelayNumber.created_at Fix MPP-3726
Fix style errors from black
jwhitlock
requested changes
Feb 1, 2024
There was a problem hiding this comment.
Thanks @say-yawn! This looks good, and I like the tests as well.
I think @override_settings(PHONES_NO_CLIENT_CALLS_IN_TEST=True) is a better solution than disconnecting and reconnecting the signal, and makes it unnecessary to disconnect the signal. Let's simplify the code and just use @override_settings as a class decorator.
| return None | ||
| except RelayNumber.DoesNotExist: | ||
| return real_phone.verified_date | ||
| return relay_number.created_at or real_phone.verified_date |
There was a problem hiding this comment.
Clever, I wondered how you were going to do this without populating created_at
| assert self.profile.has_phone is True | ||
|
|
||
|
|
||
| @pytest.mark.skipif(not settings.PHONES_ENABLED, reason="PHONES_ENABLED is False") |
| @@ -182,7 +182,7 @@ def mark_verified(self): | |||
| return self | |||
|
|
|||
|
|
|||
| @receiver(post_save, sender=RealPhone) | |||
| @receiver(post_save, sender=RealPhone, dispatch_uid="realphone_post_save") | |||
There was a problem hiding this comment.
Even though we don't need it for this change, a dispatch_uid is still a good idea, so please keep this.
say-yawn
deleted the
MPP-3726-verified-Return-real-phone-registered-date
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature description
To supply helpful data to users on Relay add-on's phone tab, provide when the user set registered their phone.
/api/v1/profileshas a new keydate_phone_registeredthat:How to test
Go to
/api/v1/profilesand check that there isdate_phone_registeredthat returns the values described in above sectionChecklist (Definition of Done)