MPP-3644: Update more uses of useIsLoggedIn
#4455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwhitlock
force-pushed
the
fix-always-logged-in-mpp-3644
branch
from
517a02f to
232a5cd
Compare
Previously, this returned true or false, but now it returns "unknown", "logged-in", or "logged-out". Update some more checks that expected a boolean.
jwhitlock
force-pushed
the
fix-always-logged-in-mpp-3644
branch
from
232a5cd to
0c55db8
Compare
rafeerahman
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Thanks, confirmed that the tests pass locally, and double checked the uses of useIsLoggedIn.
(non-blocking)
I believe profilesData.isLoading (isLoading comes from useSWR) could be used here instead of checking. I think they accomplish the same thing so it doesn't really matter.
Good suggestion, this worked for me locally and will be easier to find in the documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this returned
trueorfalse, but now it returns "unknown", "logged-in", or "logged-out". Update some more checks that expected a boolean.This is (one of?) the causes of the failing Playwright tests, and was caused by #4392. One indication is that the logo in the upper left always links to
/accounts/profile, even when logged-out.