Additions to run tests locally #4456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groovecoder
approved these changes
Mar 1, 2024
e2e-tests/e2eTestUtils/helpers.ts
Outdated
| @@ -3,13 +3,15 @@ import { APIRequestContext, Page, request } from '@playwright/test'; | |||
| export const ENV_DOMAINS = { | |||
There was a problem hiding this comment.
quibble (non-blocking): change this from ENV_DOMAINS to ENV_EMAIL_DOMAINS.
jwhitlock
approved these changes
Mar 1, 2024
e2e-tests/README.md
Outdated
| @@ -44,4 +44,8 @@ E2E_TEST_ACCOUNT_PASSWORD=<arbitrary password> | |||
| npm run test:e2e | |||
| ``` | |||
|
|
|||
| By default, `npm run test:e2e` will run the tests on https://stage.fxprivaterelay.nonprod.cloudops.mozgcp.net/. | |||
|
|
|||
| You can also run tests locally, on our dev server (https://dev.fxprivaterelay.nonprod.cloudops.mozgcp.net/), and in production (https://relay.firefox.com/). You can find the commands [here](https://github.com/mozilla/fx-private-relay/blob/main/package.json#L26-L31). To view the tests live in the browser, you can add `--headed` to the end of the command in the script. | |||
There was a problem hiding this comment.
I've been using --ui, looks like --headed is slightly different in a way. I think anyone doing debugging needs to use playwright directly rather than npm run dev:local. But, now they are a click away from some sample commands, 👍.
rafeerahman
force-pushed
the
e2e-local-instructions-readme
branch
from
7798765 to
771d66a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a local url to enable running the tests locally. Also made some additions to the e2e readme docs.
Checklist (Definition of Done)
/frontend/src/styles/tokens.scss).