Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPP-3686: Fix iOS overflow breaking for mask text in delete modal #4480

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

rafeerahman
Copy link
Contributor

@rafeerahman rafeerahman commented Mar 7, 2024

This PR fixes MPP-3686.

Bug description

When opening the delete modal on iOS devices, or holding the cancel button in the modal, the text for the users mask can go off of the modal and does not correctly wrap around.

Screenshot (if applicable)

image

How to test

  1. Navigate to the Relay email mask dashboard;

  2. Open any mask and tap on the “Delete” button;

  3. Observe the layout of the long Stage mask;

  4. Tap and hold tap on the “Cancel” button of the delete mask modal;

  5. Observe the behaviour;

Checklist (Definition of Done)

  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • Customer Experience team has seen or waived a demo of functionality.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • I've added or updated relevant docs in the docs/ directory
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.
  • All UI revisions follow the coding standards, and use Protocol tokens where applicable (see /frontend/src/styles/tokens.scss).
  • Commits in this PR are minimal and have descriptive commit messages.
  • l10n changes have been submitted to the l10n repository, if any.

Copy link
Member

@jwhitlock jwhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rafeerahman!

@jwhitlock jwhitlock added this pull request to the merge queue Mar 11, 2024
Merged via the queue into main with commit 89c496f Mar 11, 2024
27 checks passed
@jwhitlock jwhitlock deleted the MPP-3686 branch March 11, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants