MPP-79: ADR 0004, Use Code Linters to Enforce Layout and Discover Issues #4571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready to review |
groovecoder
approved these changes
Apr 10, 2024
say-yawn
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Learned a lot more about when and how to choose a linter. Thanks for this helpful ADR, @jwhitlock. Recommendation to use ruff sounds good to me too.
|
Thanks for the reviews! I'm updating the status then merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress - First draft complete. I'll revise tomorrow.
As suggested on #3858 (review), this ADR addresses code linters on Relay, identifies a gap in linting for Python, and suggests
rufffor filling that gap.