Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove client_id, mask_id from email event data #4572

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Conversation

jwhitlock
Copy link
Member

As requested at https://bugzilla.mozilla.org/show_bug.cgi?id=1882565#c5, this removes client_id from the email event data. This is draft until we've gotten re-approval.

@jwhitlock jwhitlock marked this pull request as draft April 5, 2024 15:15
@jwhitlock jwhitlock force-pushed the remove-glean-data-3641 branch from b7b97c9 to 1143648 Compare April 16, 2024 18:58
@jwhitlock jwhitlock marked this pull request as ready for review April 16, 2024 19:08
@jwhitlock
Copy link
Member Author

The data reviewer thinks the mask_id is sensitive data. I've removed it as well.

There may be more changes, but this is ready for review.

@jwhitlock jwhitlock requested a review from groovecoder April 16, 2024 19:08
@jwhitlock jwhitlock changed the title Remove client_id from email event data Remove client_id, mask_id from email event data Apr 16, 2024
@rafeerahman rafeerahman self-requested a review April 17, 2024 18:42
@jwhitlock jwhitlock added this pull request to the merge queue Apr 17, 2024
Merged via the queue into main with commit a839890 Apr 17, 2024
27 checks passed
@jwhitlock jwhitlock deleted the remove-glean-data-3641 branch April 17, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants