MPP-3786: Add type hints, make changes for browsable API #4590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These properties are used in the API, and the hints are used by drf_spectacular for documentation. This includes the suggest change in Profile.emails_replied to use the default=0 parameter available in Django 4.2.
Add type annotations and return Model.objects.none(), so that drf_spectacular can determine the QuerySet type outside of an authenticated request.
jwhitlock
force-pushed
the
browsable-api-mpp-3786
branch
from
65a07b9 to
518bba9
Compare
groovecoder
requested changes
Apr 15, 2024
|
🤦 yep, you are correct, it is the |
groovecoder
approved these changes
Apr 16, 2024
| @@ -0,0 +1,39 @@ | |||
| """Schema Extensions for drf-spectacular""" | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make changes to make
drf_spectaculara bit happier.How to test:
./manage.py check --deployonmain. See lots ofdrf_spectacular.W001anddrf_spectacular.W002warnings../manage.py check --deployon this branch. See nodrf_spectacular.W001warnings, butdrf_spectacular.W002warnings remain.