MPP-3786: More settings changes for dockerflow #4609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor CSP settings to be in one section, and in the order they appear in the Content-Security-Policy header. The 'unsafe-inline' directive is ignored if there are nonce or hash sources in the same directive. So, if we're using 'unsafe-inline', then don't compute or use the hashes for the style-src.
Allow the environment to silence more system checks, used by dockerflow for __heartbeat__. Ensure "models.W040" is included, even if not specified.
jwhitlock
force-pushed
the
more-dockerflow-mpp-3786
branch
from
da0ebb5 to
6d78df4
Compare
rafeerahman
approved these changes
Apr 17, 2024
rafeerahman
pushed a commit
that referenced
this pull request
Apr 18, 2024
MPP-3786: More settings changes for dockerflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content-Security-Policy(CSP) settings:_for variables only used inprivaterelay/settings.pyFXA_BASE_ORIGINinstead ofFXA_PROFILE_ENDPOINTconnect_src'unsafe-inline'is used for styles, do not include hashes instyle-src. If they are included, browsers will ignoreunsafe-inline.DJANGO_SECURE_SSL_REDIRECTis converted to bool forSECURE_SSL_REDIRECTSILENCED_SYSTEM_CHECKSfrom the environmentHow to test
I pushed this branch to the dev server to test. With the proper environment settings, https://dev.fxprivaterelay.nonprod.cloudops.mozgcp.net/__heartbeat__ shows
{"status": "ok"}, and no CSP issues on the dashboard or API docs.The CSP changes are targeted at local development and the dev server. The
/api/v1/docsURL looks like this on main:With this PR, inline style is allowed, so there is a grey background applied:
For
/api/v1/docs/redoc, the sidebar floats a little from the edge:With this PR, the sidebar hugs the edge: