Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPP-3779: E2E test fixes and additions #4612

Merged
merged 6 commits into from
Apr 24, 2024
Merged

Conversation

rafeerahman
Copy link
Contributor

@rafeerahman rafeerahman commented Apr 18, 2024

This PR fixes MPP-3779.

Summary of work

How to test

Checklist (Definition of Done)

  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • Customer Experience team has seen or waived a demo of functionality.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • I've added or updated relevant docs in the docs/ directory
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.
  • All UI revisions follow the coding standards, and use Protocol tokens where applicable (see /frontend/src/styles/tokens.scss).
  • Commits in this PR are minimal and have descriptive commit messages.
  • l10n changes have been submitted to the l10n repository, if any.

@rafeerahman rafeerahman changed the title MPP3779: E2E test fixes and additions MPP-3779: E2E test fixes and additions Apr 18, 2024
@rafeerahman rafeerahman added the 🚧 WIP Work in Progress label Apr 18, 2024
@rafeerahman rafeerahman force-pushed the e2e-tests-enhancement-work branch 13 times, most recently from 6c160e1 to fb50ca3 Compare April 19, 2024 22:00
@rafeerahman rafeerahman force-pushed the e2e-tests-enhancement-work branch from fb50ca3 to 4d13f77 Compare April 22, 2024 19:25
@rafeerahman rafeerahman removed the 🚧 WIP Work in Progress label Apr 22, 2024
@rafeerahman rafeerahman force-pushed the e2e-tests-enhancement-work branch from cbf8cc0 to 7976a91 Compare April 22, 2024 21:32
Copy link
Member

@jwhitlock jwhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rafeerahman! I've got a few nits and one possible documentation error, but there's a ton of work here (thanks!), so I'd rather see it merged and fixed later if needed

.github/workflows/playwright.yml Outdated Show resolved Hide resolved
.github/workflows/relay_e2e_health.yml Outdated Show resolved Hide resolved
.github/workflows/relay_e2e_health.yml Outdated Show resolved Hide resolved
.github/workflows/relay_e2e_health.yml Outdated Show resolved Hide resolved
e2e-tests/README.md Outdated Show resolved Hide resolved
e2e-tests/README.md Outdated Show resolved Hide resolved
e2e-tests/e2eTestUtils/helpers.ts Show resolved Hide resolved
e2e-tests/e2eTestUtils/helpers.ts Show resolved Hide resolved
playwright.config.ts Show resolved Hide resolved
Copy link
Member

@groovecoder groovecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to run this against the dev server and it failed. https://github.com/mozilla/fx-private-relay/actions/runs/8806158642/job/24170346150#logs

I think it failed because we don't have all the Stripe products & plans set up for dev like we have for stage + prod? I'd like to help set those up if we can verify that will fix the tests. I'd love these tests to run against the dev server after every merge to main so we can catch any errors ASAP.

@rafeerahman rafeerahman force-pushed the e2e-tests-enhancement-work branch from bf2df66 to 6e5aa2f Compare April 24, 2024 16:42
@rafeerahman
Copy link
Contributor Author

I tried to run this against the dev server and it failed. https://github.com/mozilla/fx-private-relay/actions/runs/8806158642/job/24170346150#logs

I think it failed because we don't have all the Stripe products & plans set up for dev like we have for stage + prod? I'd like to help set those up if we can verify that will fix the tests. I'd love these tests to run against the dev server after every merge to main so we can catch any errors ASAP.

On the dev server, the yearly and monthly "Emails" plans do not have product plans setup, so the tests fail. If the tests are ran on the dev server, I added logic to skip these specific tests for now.

Similarly, the "Emails and phones" plans does not have a monthly product plan setup, only the yearly works and clicking monthly redirects to yearly. Skipping the monthly test for now.

Dev tests passing now: https://github.com/mozilla/fx-private-relay/actions/runs/8819283497

@rafeerahman rafeerahman force-pushed the e2e-tests-enhancement-work branch 2 times, most recently from 26ccb4a to 5f26495 Compare April 24, 2024 19:43
@rafeerahman rafeerahman force-pushed the e2e-tests-enhancement-work branch from 5f26495 to aa13ab6 Compare April 24, 2024 19:50
@rafeerahman rafeerahman force-pushed the e2e-tests-enhancement-work branch from aa13ab6 to 84eb837 Compare April 24, 2024 20:17
Copy link
Member

@jwhitlock jwhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rafeerahman, the changes look good. I also can't confirm they work until they are merged 😬

on:
schedule:
- cron: '0 8 * * *'

- cron: 0 8 * * *
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok yaml lint...

.github/workflows/playwright.yml Show resolved Hide resolved
.lintstagedrc.js Show resolved Hide resolved
e2e-tests/README.md Show resolved Hide resolved
@rafeerahman rafeerahman added this pull request to the merge queue Apr 24, 2024
Merged via the queue into main with commit 93980f3 Apr 24, 2024
28 of 29 checks passed
@rafeerahman rafeerahman deleted the e2e-tests-enhancement-work branch April 24, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants