-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPP-3779: E2E test fixes and additions #4612
Conversation
6c160e1
to
fb50ca3
Compare
fb50ca3
to
4d13f77
Compare
cbf8cc0
to
7976a91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rafeerahman! I've got a few nits and one possible documentation error, but there's a ton of work here (thanks!), so I'd rather see it merged and fixed later if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to run this against the dev server and it failed. https://github.com/mozilla/fx-private-relay/actions/runs/8806158642/job/24170346150#logs
I think it failed because we don't have all the Stripe products & plans set up for dev like we have for stage + prod? I'd like to help set those up if we can verify that will fix the tests. I'd love these tests to run against the dev server after every merge to main
so we can catch any errors ASAP.
bf2df66
to
6e5aa2f
Compare
On the dev server, the yearly and monthly "Emails" plans do not have product plans setup, so the tests fail. If the tests are ran on the dev server, I added logic to skip these specific tests for now. Similarly, the "Emails and phones" plans does not have a monthly product plan setup, only the yearly works and clicking monthly redirects to yearly. Skipping the monthly test for now. Dev tests passing now: https://github.com/mozilla/fx-private-relay/actions/runs/8819283497 |
26ccb4a
to
5f26495
Compare
5f26495
to
aa13ab6
Compare
aa13ab6
to
84eb837
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rafeerahman, the changes look good. I also can't confirm they work until they are merged 😬
on: | ||
schedule: | ||
- cron: '0 8 * * *' | ||
|
||
- cron: 0 8 * * * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok yaml lint...
This PR fixes MPP-3779.
Summary of work
How to test
Stage run: https://github.com/mozilla/fx-private-relay/actions/runs/8759527060
Prod run: https://github.com/mozilla/fx-private-relay/actions/runs/8820178988/job/24213170565
Dev run: https://github.com/mozilla/fx-private-relay/actions/runs/8819283497
In select this branch and enabled 'health_check', and run. Passed, https://github.com/mozilla/fx-private-relay/actions/runs/8822492263
Checklist (Definition of Done)
/frontend/src/styles/tokens.scss
).