Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid python-ipware 2.0.4 #4613

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Avoid python-ipware 2.0.4 #4613

merged 1 commit into from
Apr 19, 2024

Conversation

jwhitlock
Copy link
Member

@jwhitlock jwhitlock commented Apr 19, 2024

python-ipware 2.0.4 breaks the test test_request_data_routable_ip_is_extracted. It works with 2.0.3.

Filed upstream as un33k/django-ipware#117.

This breaks the test "test_request_data_routable_ip_is_extracted"
@jwhitlock jwhitlock requested a review from rafeerahman April 19, 2024 18:59
Copy link
Contributor

@rafeerahman rafeerahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jwhitlock jwhitlock added this pull request to the merge queue Apr 19, 2024
Merged via the queue into main with commit c455e9a Apr 19, 2024
27 checks passed
@jwhitlock jwhitlock deleted the pip-python-ipware-2.0.4 branch April 19, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants