fix MPP-3805: get FxA SocialApp from DB at startup #4634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groovecoder
commented
Apr 22, 2024
privaterelay/apps.py
Outdated
| @@ -93,3 +94,9 @@ def fxa_verifying_keys(self) -> list[dict[str, Any]]: | |||
| keys: list[dict[str, Any]] = resp.json()["keys"] | |||
| return keys | |||
| return [] | |||
|
|
|||
| @cached_property | |||
| def fxa_social_app(self) -> Any: | |||
There was a problem hiding this comment.
note: I couldn't quite figure out how to annotate this with -> SocialApp because Django kept complaining that I couldn't load the SocialApp model until the app registry was full.
There was a problem hiding this comment.
Please take a look at https://mypy.readthedocs.io/en/stable/runtime_troubles.html#annotation-issues-at-runtime and pick one of those solutions (that isn't # type)
There was a problem hiding this comment.
How about 06661e9 ? (I tried from __future__ import annotations first, but it didn't work. 😢
jwhitlock
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #MPP-3805.
How to test:
pytestl10n changes have been submitted to the l10n repository, if any.I've added or updated relevant docs in the docs/ directory.All UI revisions follow the coding standards, and use Protocol tokens where applicable (see/frontend/src/styles/tokens.scss).