Move coverage to pyproject #4658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not measure coverage of migrations - Do measure coverage of test files - Avoid coverage of locales files
|
I can go either way on coverage for test files. The argument for excluding them is that it makes the coverage percentage higher that "deserved", since it included both production and test code. The argument for including them is that it exposes issues like test code that doesn't run as expected. So, I'm relying on reviewers to decide which way to go... |
groovecoder
approved these changes
Apr 30, 2024
|
I'd rather include them so they continue to expose issues in a way that, even if we ignore it MOST of the time, we might actually see it again and decide to pick it up. If we exclude them once, they will be forgotten forever. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm getting errors when attempting to upload coverage for
privaterelay/locales/de/banner.ftl. This PR should fix this, while also movingcoverageconfiguration topyproject.tomland adding coverage of test files.