-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPP-3799: Add schemas to API views for phones #4660
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groovecoder
approved these changes
May 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the schema details for the phones views. No changes have been made to the API code. In the future, they can be updated to use the new serializers created for documentation purposes.
How to test
With
PHONES_ENABLED=True
:POST /api/v1/call/
POST /api/v1/message/
POST /api/v1/messages/
POST /api/v1/inbound_call/
POST /api/v1/inbound_sms/
POST /api/v1/sms_status/
POST /api/v1/voice_status/
/api/v1/inboundcontact/
,/api/v1/realphone/
, and/api/v1/relaynumber
are unchanged. The changed views:POST /api/v1/realphone/resend_welcome_sms
GET /api/v1/relaynumber/search/
GET /api/v1/relaynumber/suggestions/
GET /api/v1/vCard/{lookup_key}/
With
IQ_ENABLED=True
, an additional group is available, between "phones: Twilio" and "phones":POST /api/v1/inbound_sms_iq
When running
./manage.py check --deploy
, no views inapi/views/phones.py
have adrf_spectacular.W002
warning.