fix MPP-3802: stop ignoring bandit security checks #4684
Conversation
groovecoder
force-pushed
the
enable-flak8-bandit-checks-mpp-3802
branch
4 times, most recently
from
7f9a71f to
63af71b
Compare
groovecoder
force-pushed
the
enable-flak8-bandit-checks-mpp-3802
branch
from
63af71b to
c6a71b5
Compare
There was a problem hiding this comment.
Thanks @groovecoder! Only required change from me is creating a setting for the FxA profile timeout that can be configured via the environment.
| @@ -557,15 +557,18 @@ def _cached_country_language_mapping( | |||
|
|
|||
| mapping: PlanCountryLangMapping = {} | |||
| for relay_country in relay_maps.get("by_country", []): | |||
| assert relay_country not in mapping | |||
| if relay_country in mapping: | |||
| raise ValueError("relay_country should not be in mapping.") | |||
There was a problem hiding this comment.
Nit: these will be harder to debug, since we won't know which relay_county was already in the mapping. However, we can expand the error message when we get to that point, instead of making every ValueError include the value.
There was a problem hiding this comment.
This was the change that made me wonder: should I go back thru this whole PR and include the value in every ValueError message while I'm in here? I don't mind doing that now rather than later.
groovecoder
changed the title
|
Made updates, but @jwhitlock if you think I should go ahead and include values in |
There was a problem hiding this comment.
Thanks @groovecoder!
No, I think we're OK without the detailed messages. If one of these fires in production, we'll add 1) a test to trigger the exception and 2) more information to exception message. 95% should never need it.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This PR fixes #MPP-3802.
How to test:
pytestruff check .l10n changes have been submitted to the l10n repository, if any.I've added or updated relevant docs in the docs/ directory.All UI revisions follow the coding standards, and use Protocol tokens where applicable (see/frontend/src/styles/tokens.scss).