MPP-3815: Fix email processing tests #4706
Merged
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groovecoder
approved these changes
May 13, 2024
| @@ -30,7 +30,7 @@ | |||
|
|
|||
|
|
|||
| @pytest.fixture(autouse=True) | |||
| def mocked_clocks() -> Iterator[Callable[[float], float]]: | |||
| def mocked_clocks() -> Iterator[None]: | |||
There was a problem hiding this comment.
you somehow resisted the dark urge to rename this mlocks again.
| @@ -447,7 +446,8 @@ def test_ses_slow( | |||
| assert rec2_extra["success"] is True | |||
| assert rec2_extra["message_process_time_s"] < 120.0 | |||
| assert rec2_extra["subprocess_setup_time_s"] == 1.0 | |||
| assert mock_process_pool_future._timeouts == [1.0] | |||
| # future.wait(1.0) was called 3 times, was ready after the 3rd call. | |||
There was a problem hiding this comment.
praise: nice comment. now I see how this correlates to the 3-item _is_stalled.side_effect list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a couple of test improvements suggested by @groovecoder's review of PR #4702:
test_ses_slowto actually test slow email processingfuture.wait(1.0)call to not increment the timer, and instead delegate to thetime.monotoniccall in the same loop, so the loop takes the expected 1 simulated second instead of 2 simulated seconds.