Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the events logger for warning or error levels #4744

Merged
merged 2 commits into from
May 29, 2024
Merged

Use the events logger for warning or error levels #4744

merged 2 commits into from
May 29, 2024

Conversation

jwhitlock
Copy link
Member

The GCP logging ingester treats all logs from eventsinfo as INFO-level, even if logged at WARNING or ERROR. Use events so that these issues stand out in the logs.

@jwhitlock
Use the events logger for warning or error levels
aecc919 
The GCP logging ingester treats all logs from eventsinfo as INFO-level,
even if logged at WARN or ERROR.
@jwhitlock jwhitlock requested a review from groovecoder May 28, 2024 21:31
@jwhitlock jwhitlock marked this pull request as draft May 28, 2024 21:33
@jwhitlock jwhitlock marked this pull request as ready for review May 28, 2024 21:43
say-yawn
say-yawn approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@say-yawn say-yawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Manually using different loggers is not ideal but it worked at the time when we were trying to get certain logs to stdout versus stderror on GCP logs. I created #4745 to take a look at this again.

@jwhitlock jwhitlock added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit 0203fb9 May 29, 2024
29 checks passed
@jwhitlock jwhitlock deleted the use-events-logger branch May 29, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@say-yawn say-yawn say-yawn approved these changes

@groovecoder groovecoder Awaiting requested review from groovecoder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwhitlock @say-yawn