Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @testing-library/react from 15.0.7 to 16.0.0 in the testing-library group #4772

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 10, 2024

Bumps the testing-library group with 1 update: @testing-library/react.

Updates @testing-library/react from 15.0.7 to 16.0.0

Release notes

Sourced from @​testing-library/react's releases.

v16.0.0

16.0.0 (2024-06-03)

Features

  • Move @testing-library/dom and @types/react-dom to peer dependencies (#1305) (a4744fa)

BREAKING CHANGES

  • @testing-library/dom was moved to a peer dependency and needs to be explicitly installed. This reduces the chance of having conflicting versions of @testing-library/dom installed that frequently caused bugs when used with @testing-library/user-event. We will also be able to allow new versions of @testing-library/dom being used without a SemVer major release of @testing-library/react by just widening the peer dependency. @types/react-dom needs to be installed if you're typechecking files using @testing-library/react.
Commits
  • a4744fa feat: Move @testing-library/dom and @types/react-dom to peer dependencie...
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jun 10, 2024
Bumps the testing-library group with 1 update: [@testing-library/react](https://github.com/testing-library/react-testing-library).


Updates `@testing-library/react` from 15.0.7 to 16.0.0
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v15.0.7...v16.0.0)

---
updated-dependencies:
- dependency-name: "@testing-library/react"
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: testing-library
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/testing-library-43861c45c2 branch from 653dc62 to 2509a42 Compare June 10, 2024 14:16
Copy link
Member

@jwhitlock jwhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From BREAKING CHANGES:

@testing-library/dom was moved to a peer dependency and needs to be explicitly installed.

✓ We're doing this.

@types/react-dom needs to be installed if you're typechecking files using @testing-library/react.

We don't do this, and I'm seeing some warnings in the tests that may be related:

Warning: React does not recognize the fetchPriority prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase fetchpriority instead. If you accidentally passed it from a parent component, remove it from the DOM element.

@@ -40,7 +40,7 @@
"@next/eslint-plugin-next": "^14.2.3",
"@testing-library/dom": "^10.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're already installing @testing-library/dom

@jwhitlock
Copy link
Member

Adding @types/react-dom did not help. This appears to be because we're on react 18.3.1, which turns on warnings for the upcoming 19 release. This is a known issue, and the current work-around is to pin updates. See vercel/next.js#65161.

I'm going to go ahead with this update. No tests break, just additional known warnings about a future update.

@jwhitlock jwhitlock added this pull request to the merge queue Jun 10, 2024
Merged via the queue into main with commit 4339f3b Jun 10, 2024
29 checks passed
@jwhitlock jwhitlock deleted the dependabot/npm_and_yarn/testing-library-43861c45c2 branch June 10, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant