-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPP-3528: Recreate website metrics, add images #4793
Conversation
This rewrites METRICS.md to include all the frontend code that emits Google Analytics events, as well as sample images to make it easier to refer to buttons and text. The images are minimized for size with pngquant.
b11812a
to
c796010
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is a great thorough update to the metrics doc.
The screenshots help establish context for the pings really well, but a couple (non-blocking) concerns about including screenshots:
- We only include screenshots for the website and not the add-on
- We will have to maintain the screenshots
clicked. This allows measuring the percentage of users that click a link, and the | ||
effectiveness of different text and presentations. | ||
|
||
Here is a summary of the event categories and actions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (non-blocking):
Here is a summary of the event categories and actions: | |
Here is an in-depth table of the event categories and actions: |
😛
Yep, the new detailed sections only cover the website. The add-on documentation (called an "Extension", we should revisit if we want to use that) is untouched and at the bottom of the document. I hope to tackle that next.
A few thoughts:
|
This rewrites
METRICS.md
to include all the frontend code that emits Google Analytics events, as well as sample images to make it easier to refer to buttons and text.The images are minimized for size with pngquant. They are displayed at 1/3 width, and can be clicked to see the full image.
How to test:
frontend/src
.