update script-src and worker-src directives #4838
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Tag Manager needs
script-src: unsafe-inline
andworker-src: blob:
. I created this branch to test these updates on the dev server.This fix already works on dev, because
API_DOCS_ENABLED
is set toTrue
.For stage & prod, we will need to set two new env vars:
CSP_SCRIPT_UNSAFE_INLINE=True
CSP_WORKER_BLOB=True
How to test on dev:
How to test on stage:
CSP_SCRIPT_UNSAFE_INLINE=True
CSP_WORKER_BLOB=True
l10n changes have been submitted to the l10n repository, if any.I've added a unit test to test for potential regressions of this bug.All UI revisions follow the coding standards, and use Protocol tokens where applicable (see/frontend/src/styles/tokens.scss
).Commits in this PR are minimal and have descriptive commit messages.