Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPP-3528: Update metrics doc for the extension #4855

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

jwhitlock
Copy link
Member

This PR updates METRICS.md with the current Google Analytics metrics emitted by the extension. The extension source code is at https://github.com/mozilla/fx-private-relay-add-on/, and all the metrics go through the background function sendMetricsEvent

https://github.com/mozilla/fx-private-relay-add-on/blob/9d3794c7e0c554503ed3210091f33da5a0199194/src/js/background/background.js#L256

Other changes:

  • Fixed some grammar and spelling issues in the existing document
  • Changed existing HTML ids from a prefix ctx-* to ctx-web-, and used ctx-ext- for the new ones
  • Renamed existing PNG images to have a prefix website-*, and used extension-* for the extension images.
  • Expanded the README in the images folder, and split out the script into compress_images.bash

To prepare for extension screenshots, prefix images with 'website-' and
the context anchors with `ctx-web-`.

Swap an image that contained an invalid email.
Copy link
Member

@groovecoder groovecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thorough update!


The Google Analytics events:

- The user sees the " button in the "Introducing: Relay + VPN subscription plan" banner
on the email masks page.
- The user sees the "Upgrade Now" button in the "Introducing: Relay + VPN
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: 🦅 👁️ fix.


The "Help & Tips" box appears in the lower right corner of the Email Masks Dashboard
and the Phone Masks Dashboard when the conditions for the tip is met. It is first
and the Phone Masks Dashboard when the conditions for the tip are met. It is first
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: 🦅 👁️


The top "call to action" button, labelled 'Upgrade Now', takes the user to the plan
The top "call to action" button, labeled 'Upgrade Now', takes the user to the plan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: 🦅 👁️

@groovecoder groovecoder added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit 639965b Jul 15, 2024
29 checks passed
@groovecoder groovecoder deleted the extension-metrics-mpp3528 branch July 15, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants