Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old intro pricing news entry #4878

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

groovecoder
Copy link
Member

@groovecoder groovecoder commented Jul 15, 2024

This PR removes the intro pricing news entry: the only part of the code that dependended on fast-check, so we don't have to keep up with its updates.

How to test:

  1. cd frontend && npm run watch
  2. python manage.py collectstatic
  3. python manage.py runserver
  4. Sign in to http://127.0.0.1:8000/accounts/profile/
  5. Click "News" in the top navigation
  6. Click the "History" pill button
    • You should NOT see the news item about introductory pricing (note: a waffle flag might already be hiding it)
    • The rest of the News items should all still work
  • l10n changes have been submitted to the l10n repository, if any.
  • I've added a unit test to test for potential regressions of this bug.
  • I've added or updated relevant docs in the docs/ directory.
  • All UI revisions follow the coding standards, and use Protocol tokens where applicable (see /frontend/src/styles/tokens.scss).
  • Commits in this PR are minimal and have descriptive commit messages.

@groovecoder groovecoder requested a review from rafeerahman July 15, 2024 16:46
@groovecoder groovecoder force-pushed the remove-intro-pricing-news-item branch 2 times, most recently from 3b170be to a2074f5 Compare July 16, 2024 19:51
@groovecoder groovecoder force-pushed the remove-intro-pricing-news-item branch from a2074f5 to cd65baf Compare July 16, 2024 20:07
Copy link
Contributor

@rafeerahman rafeerahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, the I don't see the introductory pricing news item anymore.

@groovecoder groovecoder added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 88ef5d5 Jul 16, 2024
29 checks passed
@groovecoder groovecoder deleted the remove-intro-pricing-news-item branch July 16, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants