MPP-3839: Handle trailing newline in headers #4879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groovecoder
approved these changes
Jul 15, 2024
| @@ -0,0 +1,17 @@ | |||
| Date: Tue, 09 Jul 2024 20:02:30 +0200 | |||
| Subject: An =?UTF-8?Q?encoded_newline=0A?= | |||
There was a problem hiding this comment.
praise: thank you for plumbing the depths of email content down to the character level!
|
quibble: this fixes the GitHub issue 4841 not the MPP-4841 ticket. |
jwhitlock
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python
emaillibrary does not expect newlines in header values. It rejects newlines with aValueError, except when the newline is at the end of the value. A newline can be present in the incoming email due to encoding. This newline is injected into the forwarded email. The mail client interprets this as the start of the email, and stops header processing.This PR strips any trailing newlines from the header value, fixing issue #4841.
How to test: