Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to gunicorn.conf.py #4884

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Rename to gunicorn.conf.py #4884

merged 1 commit into from
Jul 16, 2024

Conversation

jwhitlock
Copy link
Member

gunicorn.conf.py has been the default since 17.5 (2013-07-03), and gunicorn starts with a warning if the config file doesn't end in .py.

How to test:

On main, you can run this to see the error:

gunicorn --config gunicorn.conf privaterelay.wsgi:application

You can also see it in the GCP logs with this query:

textPayload=~"^!!!"
severity=ERROR
labels."k8s-pod/app_kubernetes_io/name"="fxprivaterelay"

On this branch, you can run without the --config argument and get no error:

gunicorn privaterelay.wsgi:application

This is the default since 17.5 (2013-07-03), and gunicorn starts with a
warning if it doesn't end in .py
@groovecoder groovecoder added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit ad36148 Jul 16, 2024
29 checks passed
@groovecoder groovecoder deleted the rename-gunicorn-conf branch July 16, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants