Added a user allow list to ignore abuse metrics, avoid race conditions in abuse metrics #4885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng abuse metric updates
jwhitlock
approved these changes
Jul 19, 2024
| ).astimezone(UTC) | ||
| midnight_utc_tomorow = midnight_utc_today + timedelta(days=1) | ||
| abuse_metric = ( | ||
| self.user.abusemetrics_set.select_for_update() |
| @@ -929,5 +929,8 @@ def set_index_cache_control_headers( | |||
| # django-ftl settings | |||
| AUTO_RELOAD_BUNDLES = False # Requires pyinotify | |||
|
|
|||
| # accounts that should not have abuse metrics | |||
| ALLOWED_ACCOUNTS = ["[email protected]"] | |||
There was a problem hiding this comment.
Normally we'd load this from the environment, but we can do that when we first need it.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes MPP-3720, MPP-3806.
Description
Adds atomic transaction and row locking for updating abuse metrics.
Also adds an 'allow' list so that our e2e test accounts do not get flagged.
Screenshot (if applicable)
Not applicable.
Checklist (Definition of Done)
/frontend/src/styles/tokens.scss).